Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename fails when only 1 column is specified #79

Closed
ghost opened this issue Oct 17, 2018 · 3 comments
Closed

rename fails when only 1 column is specified #79

ghost opened this issue Oct 17, 2018 · 3 comments
Labels
bug rename

Comments

@ghost
Copy link

@ghost ghost commented Oct 17, 2018

@EmilHvitfeldt commented on Oct 17, 2018, 5:32 AM UTC:

When using rename with !! and strings it fails if only 1 column is used. However it is not a problem when unquoting symbols.

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
vars <- c(var1 = "cyl", var2 = "am")
rename(mtcars, !!vars)
#>                      mpg var1  disp  hp drat    wt  qsec vs var2 gear carb
#> Mazda RX4           21.0    6 160.0 110 3.90 2.620 16.46  0    1    4    4
#> Mazda RX4 Wag       21.0    6 160.0 110 3.90 2.875 17.02  0    1    4    4
#> Datsun 710          22.8    4 108.0  93 3.85 2.320 18.61  1    1    4    1
#> Hornet 4 Drive      21.4    6 258.0 110 3.08 3.215 19.44  1    0    3    1
#> Hornet Sportabout   18.7    8 360.0 175 3.15 3.440 17.02  0    0    3    2
#> Valiant             18.1    6 225.0 105 2.76 3.460 20.22  1    0    3    1
#> Duster 360          14.3    8 360.0 245 3.21 3.570 15.84  0    0    3    4
#> Merc 240D           24.4    4 146.7  62 3.69 3.190 20.00  1    0    4    2
#> Merc 230            22.8    4 140.8  95 3.92 3.150 22.90  1    0    4    2
#> Merc 280            19.2    6 167.6 123 3.92 3.440 18.30  1    0    4    4
#> Merc 280C           17.8    6 167.6 123 3.92 3.440 18.90  1    0    4    4
#> Merc 450SE          16.4    8 275.8 180 3.07 4.070 17.40  0    0    3    3
#> Merc 450SL          17.3    8 275.8 180 3.07 3.730 17.60  0    0    3    3
#> Merc 450SLC         15.2    8 275.8 180 3.07 3.780 18.00  0    0    3    3
#> Cadillac Fleetwood  10.4    8 472.0 205 2.93 5.250 17.98  0    0    3    4
#> Lincoln Continental 10.4    8 460.0 215 3.00 5.424 17.82  0    0    3    4
#> Chrysler Imperial   14.7    8 440.0 230 3.23 5.345 17.42  0    0    3    4
#> Fiat 128            32.4    4  78.7  66 4.08 2.200 19.47  1    1    4    1
#> Honda Civic         30.4    4  75.7  52 4.93 1.615 18.52  1    1    4    2
#> Toyota Corolla      33.9    4  71.1  65 4.22 1.835 19.90  1    1    4    1
#> Toyota Corona       21.5    4 120.1  97 3.70 2.465 20.01  1    0    3    1
#> Dodge Challenger    15.5    8 318.0 150 2.76 3.520 16.87  0    0    3    2
#> AMC Javelin         15.2    8 304.0 150 3.15 3.435 17.30  0    0    3    2
#> Camaro Z28          13.3    8 350.0 245 3.73 3.840 15.41  0    0    3    4
#> Pontiac Firebird    19.2    8 400.0 175 3.08 3.845 17.05  0    0    3    2
#> Fiat X1-9           27.3    4  79.0  66 4.08 1.935 18.90  1    1    4    1
#> Porsche 914-2       26.0    4 120.3  91 4.43 2.140 16.70  0    1    5    2
#> Lotus Europa        30.4    4  95.1 113 3.77 1.513 16.90  1    1    5    2
#> Ford Pantera L      15.8    8 351.0 264 4.22 3.170 14.50  0    1    5    4
#> Ferrari Dino        19.7    6 145.0 175 3.62 2.770 15.50  0    1    5    6
#> Maserati Bora       15.0    8 301.0 335 3.54 3.570 14.60  0    1    5    8
#> Volvo 142E          21.4    4 121.0 109 4.11 2.780 18.60  1    1    4    2

vars <- c(var1 = "cyl")
rename(mtcars, !!vars)
#> Error: All arguments must be named

vars <- list(
  var1 = sym("cyl"),
  var2 = sym("am")
)
rename(mtcars, !!!vars)
#>                      mpg var1  disp  hp drat    wt  qsec vs var2 gear carb
#> Mazda RX4           21.0    6 160.0 110 3.90 2.620 16.46  0    1    4    4
#> Mazda RX4 Wag       21.0    6 160.0 110 3.90 2.875 17.02  0    1    4    4
#> Datsun 710          22.8    4 108.0  93 3.85 2.320 18.61  1    1    4    1
#> Hornet 4 Drive      21.4    6 258.0 110 3.08 3.215 19.44  1    0    3    1
#> Hornet Sportabout   18.7    8 360.0 175 3.15 3.440 17.02  0    0    3    2
#> Valiant             18.1    6 225.0 105 2.76 3.460 20.22  1    0    3    1
#> Duster 360          14.3    8 360.0 245 3.21 3.570 15.84  0    0    3    4
#> Merc 240D           24.4    4 146.7  62 3.69 3.190 20.00  1    0    4    2
#> Merc 230            22.8    4 140.8  95 3.92 3.150 22.90  1    0    4    2
#> Merc 280            19.2    6 167.6 123 3.92 3.440 18.30  1    0    4    4
#> Merc 280C           17.8    6 167.6 123 3.92 3.440 18.90  1    0    4    4
#> Merc 450SE          16.4    8 275.8 180 3.07 4.070 17.40  0    0    3    3
#> Merc 450SL          17.3    8 275.8 180 3.07 3.730 17.60  0    0    3    3
#> Merc 450SLC         15.2    8 275.8 180 3.07 3.780 18.00  0    0    3    3
#> Cadillac Fleetwood  10.4    8 472.0 205 2.93 5.250 17.98  0    0    3    4
#> Lincoln Continental 10.4    8 460.0 215 3.00 5.424 17.82  0    0    3    4
#> Chrysler Imperial   14.7    8 440.0 230 3.23 5.345 17.42  0    0    3    4
#> Fiat 128            32.4    4  78.7  66 4.08 2.200 19.47  1    1    4    1
#> Honda Civic         30.4    4  75.7  52 4.93 1.615 18.52  1    1    4    2
#> Toyota Corolla      33.9    4  71.1  65 4.22 1.835 19.90  1    1    4    1
#> Toyota Corona       21.5    4 120.1  97 3.70 2.465 20.01  1    0    3    1
#> Dodge Challenger    15.5    8 318.0 150 2.76 3.520 16.87  0    0    3    2
#> AMC Javelin         15.2    8 304.0 150 3.15 3.435 17.30  0    0    3    2
#> Camaro Z28          13.3    8 350.0 245 3.73 3.840 15.41  0    0    3    4
#> Pontiac Firebird    19.2    8 400.0 175 3.08 3.845 17.05  0    0    3    2
#> Fiat X1-9           27.3    4  79.0  66 4.08 1.935 18.90  1    1    4    1
#> Porsche 914-2       26.0    4 120.3  91 4.43 2.140 16.70  0    1    5    2
#> Lotus Europa        30.4    4  95.1 113 3.77 1.513 16.90  1    1    5    2
#> Ford Pantera L      15.8    8 351.0 264 4.22 3.170 14.50  0    1    5    4
#> Ferrari Dino        19.7    6 145.0 175 3.62 2.770 15.50  0    1    5    6
#> Maserati Bora       15.0    8 301.0 335 3.54 3.570 14.60  0    1    5    8
#> Volvo 142E          21.4    4 121.0 109 4.11 2.780 18.60  1    1    4    2

vars <- list(
  var1 = sym("cyl")
)
rename(mtcars, !!!vars)
#>                      mpg var1  disp  hp drat    wt  qsec vs am gear carb
#> Mazda RX4           21.0    6 160.0 110 3.90 2.620 16.46  0  1    4    4
#> Mazda RX4 Wag       21.0    6 160.0 110 3.90 2.875 17.02  0  1    4    4
#> Datsun 710          22.8    4 108.0  93 3.85 2.320 18.61  1  1    4    1
#> Hornet 4 Drive      21.4    6 258.0 110 3.08 3.215 19.44  1  0    3    1
#> Hornet Sportabout   18.7    8 360.0 175 3.15 3.440 17.02  0  0    3    2
#> Valiant             18.1    6 225.0 105 2.76 3.460 20.22  1  0    3    1
#> Duster 360          14.3    8 360.0 245 3.21 3.570 15.84  0  0    3    4
#> Merc 240D           24.4    4 146.7  62 3.69 3.190 20.00  1  0    4    2
#> Merc 230            22.8    4 140.8  95 3.92 3.150 22.90  1  0    4    2
#> Merc 280            19.2    6 167.6 123 3.92 3.440 18.30  1  0    4    4
#> Merc 280C           17.8    6 167.6 123 3.92 3.440 18.90  1  0    4    4
#> Merc 450SE          16.4    8 275.8 180 3.07 4.070 17.40  0  0    3    3
#> Merc 450SL          17.3    8 275.8 180 3.07 3.730 17.60  0  0    3    3
#> Merc 450SLC         15.2    8 275.8 180 3.07 3.780 18.00  0  0    3    3
#> Cadillac Fleetwood  10.4    8 472.0 205 2.93 5.250 17.98  0  0    3    4
#> Lincoln Continental 10.4    8 460.0 215 3.00 5.424 17.82  0  0    3    4
#> Chrysler Imperial   14.7    8 440.0 230 3.23 5.345 17.42  0  0    3    4
#> Fiat 128            32.4    4  78.7  66 4.08 2.200 19.47  1  1    4    1
#> Honda Civic         30.4    4  75.7  52 4.93 1.615 18.52  1  1    4    2
#> Toyota Corolla      33.9    4  71.1  65 4.22 1.835 19.90  1  1    4    1
#> Toyota Corona       21.5    4 120.1  97 3.70 2.465 20.01  1  0    3    1
#> Dodge Challenger    15.5    8 318.0 150 2.76 3.520 16.87  0  0    3    2
#> AMC Javelin         15.2    8 304.0 150 3.15 3.435 17.30  0  0    3    2
#> Camaro Z28          13.3    8 350.0 245 3.73 3.840 15.41  0  0    3    4
#> Pontiac Firebird    19.2    8 400.0 175 3.08 3.845 17.05  0  0    3    2
#> Fiat X1-9           27.3    4  79.0  66 4.08 1.935 18.90  1  1    4    1
#> Porsche 914-2       26.0    4 120.3  91 4.43 2.140 16.70  0  1    5    2
#> Lotus Europa        30.4    4  95.1 113 3.77 1.513 16.90  1  1    5    2
#> Ford Pantera L      15.8    8 351.0 264 4.22 3.170 14.50  0  1    5    4
#> Ferrari Dino        19.7    6 145.0 175 3.62 2.770 15.50  0  1    5    6
#> Maserati Bora       15.0    8 301.0 335 3.54 3.570 14.60  0  1    5    8
#> Volvo 142E          21.4    4 121.0 109 4.11 2.780 18.60  1  1    4    2

Created on 2018-10-16 by the reprex package (v0.2.1)

This issue was moved by romainfrancois from tidyverse/dplyr#3916.

@ghost
Copy link
Author

@ghost ghost commented Oct 17, 2018

@EmilHvitfeldt commented on Oct 17, 2018, 5:44 AM UTC:

I was able to fix it by using !!! instead of !! but the behavior is still surprising to me.

@ghost
Copy link
Author

@ghost ghost commented Oct 17, 2018

@romainfrancois commented on Oct 17, 2018, 8:49 AM UTC:

This seems to be related to this line in tidy select: https://github.com/tidyverse/tidyselect/blob/0ea6d5488e423db5feafb8cbe86cee86897d7aca/R/vars-rename.R#L8

unquoted_chrs <- map_lgl(quos, quo_is_character, n = function(n) n > 1)

@romainfrancois
Copy link
Collaborator

@romainfrancois romainfrancois commented Oct 17, 2018

library(tidyselect)

vars <- c("x", "y")
vars_rename(vars, !!c(X = "x", Y = "y"))
#>   X   Y 
#> "x" "y"
vars_rename(vars, !!c(X = "x"))
#> Error: All arguments must be named

Created on 2018-10-17 by the reprex package (v0.2.1.9000)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rename
Projects
None yet
Development

No branches or pull requests

2 participants