Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_github_release() can tag the wrong commit #1029

Closed
davidchall opened this issue Mar 6, 2020 · 0 comments · Fixed by #1031
Closed

use_github_release() can tag the wrong commit #1029

davidchall opened this issue Mar 6, 2020 · 0 comments · Fixed by #1031

Comments

@davidchall
Copy link
Contributor

@davidchall davidchall commented Mar 6, 2020

The use_github_release() function creates a draft GitHub Release using the corresponding GitHub API. However, it doesn't set the target_commitish field and so GitHub uses the default branch (usually master).

There are situations where your local HEAD doesn't correspond to the remote default branch. For example, when releasing patches from a non-master branch. In this case, use_github_release() checks that local commits have been pushed to the remote, but then tags the wrong commit. I think this function should probably be tagging the most recent local commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant