Skip to content

What to do about use_tidy_ci()? #1098

Description

@jennybc

While reviewing #1096, I noticed that use_tidy_ci() has not kept up with our transition away from Travis and AppVeyor and towards Github Actions:

usethis/R/tidyverse.R

Lines 98 to 121 in a132195

use_tidy_ci <- function(browse = rlang::is_interactive()) {
check_uses_github()
new_travis <- use_template(
"tidy-travis.yml",
".travis.yml",
ignore = TRUE
)
use_template("codecov.yml", ignore = TRUE)
use_dependency("R", "Depends", min_version = "3.2")
use_dependency("covr", "Suggests")
use_covr_ignore(c("R/deprec-*.R", "R/compat-*.R"))
use_travis_badge()
use_codecov_badge()
use_tidy_release_test_env()
if (new_travis) {
travis_activate(browse)
}
invisible(TRUE)
}

Do we want to just ignore it? Or do we want to make it do different things? As in, it could just be an alias for use_tidy_github_actions():

use_tidy_github_actions <- function() {
check_uses_github()
use_coverage()
full_status <- use_github_action_check_full()
pr_status <- use_github_action_pr_commands()
pkgdown_status <- use_github_action("pkgdown")
test_coverage_status <- use_github_action("test-coverage")
old_configs <- proj_path(c(".travis.yml", "appveyor.yml"))
has_appveyor_travis <- file_exists(old_configs)
if (any(has_appveyor_travis)) {
if (ui_yeah(
"Remove existing {ui_path('.travis.yml')} and {ui_path('appveyor.yml')}?"
)) {
file_delete(old_configs[has_appveyor_travis])
ui_todo("Remove old badges from README")
}
}
invisible(full_status && pr_status && pkgdown_status && test_coverage_status)
}

cc @hadley @jimhester

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featurea feature request or enhancementgitgit, GitHub, and CI in generaltidy ✨tools for the tidyverse team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions