Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically use testthat 3e #1185

Closed
hadley opened this issue Jul 12, 2020 · 3 comments · Fixed by #1205
Closed

Automatically use testthat 3e #1185

hadley opened this issue Jul 12, 2020 · 3 comments · Fixed by #1205
Labels
feature a feature request or enhancement tidy ✨ tools for the tidyverse team

Comments

@hadley
Copy link
Member

hadley commented Jul 12, 2020

When creating a package and you have testthat 3.0.0 or later installed.

We may also want to provide use_testthat_3e() function.
@jennybc jennybc added feature a feature request or enhancement tidy ✨ tools for the tidyverse team labels Jul 12, 2020
@hadley
Copy link
Member Author

hadley commented Jul 12, 2020

(FWIW this isn't just for us, but is for everyone)

@jennybc
Copy link
Member

jennybc commented Jul 12, 2020

I know but I was trying to find a label in addition to "feature" 😁

Seems like a good time to ask: Is this what the "code 🖥️" label is for?

@hadley
Copy link
Member Author

hadley commented Sep 2, 2020

Should just add edition argument to use_testthat and default to 3 if appropriate version of testthat found.

hadley added a commit that referenced this issue Sep 2, 2020
@hadley
Set edition in use_testthat()
78a3587 
Fixes #1185
@hadley hadley mentioned this issue Sep 2, 2020
Merged
hadley added a commit that referenced this issue Sep 2, 2020
@hadley
Set edition in use_testthat() (#1205)
0f04463 
Fixes #1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement tidy ✨ tools for the tidyverse team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set edition in use_testthat() r-lib/usethis
2 participants
@hadley @jennybc