Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream repository in README development installation #1312

Closed
llrs opened this issue Dec 16, 2020 · 2 comments · Fixed by #1315
Closed

Use upstream repository in README development installation #1312

llrs opened this issue Dec 16, 2020 · 2 comments · Fixed by #1315
Labels
git git, GitHub, and CI in general

Comments

@llrs
Copy link
Contributor

llrs commented Dec 16, 2020

when creating a README (I think both Rmd and .md) there are some automatic instructions to install a package from the development repository.
Currently origin remote is used, but in a fork I think it should use upstream. If not a question about which one to use as in use_github_links() might be helpful to avoid later a potentially merge conflict.
@jennybc
Copy link
Member

jennybc commented Dec 18, 2020

Yes good point.

@jennybc jennybc added the git git, GitHub, and CI in general label Dec 18, 2020
@jennybc jennybc mentioned this issue Dec 20, 2020
Merged
@llrs
Copy link
Contributor Author

llrs commented Dec 20, 2020

Thanks, that was quick but more complicated than I though.
I was about to look into this and create a PR, glad you closed it first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git git, GitHub, and CI in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminate project_data() r-lib/usethis
2 participants
@jennybc @llrs