New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_github_release() should use data in CRAN-RELEASE #1380
Comments
jennybc
added a commit
that referenced
this issue
Mar 4, 2021
jennybc
added a commit
that referenced
this issue
Oct 13, 2021
jennybc
added a commit
to r-lib/devtools
that referenced
this issue
Oct 13, 2021
jennybc
added a commit
to r-lib/devtools
that referenced
this issue
Oct 13, 2021
jennybc
added a commit
to r-lib/devtools
that referenced
this issue
Oct 14, 2021
…mans (#2379) * Put more info into CRAN-RELEASE and write it for computers, not humans Relates to #2139 and r-lib/usethis#1380 * Harmonize with DESCRIPTION * Record time as well as day * Format the time stamp more like CRAN does in DESCRIPTION * Whitespace * NEWS bullet * Switch to CRAN-SUBMISSION
jennybc
added a commit
that referenced
this issue
Oct 15, 2021
jennybc
added a commit
that referenced
this issue
Oct 15, 2021
* Consult CRAN-RELEASE for release sha Closes #1380 * Create a helper to marshal data, from old or new CRAN-RELEASE files PR to change what devtools writes: r-lib/devtools#2379 * With old-style CRAN-RELEASE, the short SHA length isn't guaranteed Apparently the meaning of `--short` in `git-rev-parse` varies. On my machine it's 8. * Add tests * Adapt to CRAN-SUBMISSION; get DESCRIPTION and NEWS.md from GitHub if necessary * Add NEWS * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
use_github_release()
just uses the HEAD commit for the tag, really it would be better to use the commit inCRAN-RELEASE
, as that should be what was actually uploaded to CRAN.This was mentioned in r-lib/devtools#2139 (comment), but unfortunately no issue was ever opened in usethis.
The text was updated successfully, but these errors were encountered: