Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_github_release() should use data in CRAN-RELEASE #1380

Closed
jimhester opened this issue Mar 2, 2021 · 0 comments · Fixed by #1383
Closed

use_github_release() should use data in CRAN-RELEASE #1380

jimhester opened this issue Mar 2, 2021 · 0 comments · Fixed by #1383
Labels
git git, GitHub, and CI in general release 🛫 wip work in progress

Comments

@jimhester
Copy link
Member

Currently use_github_release() just uses the HEAD commit for the tag, really it would be better to use the commit in CRAN-RELEASE, as that should be what was actually uploaded to CRAN.

This was mentioned in r-lib/devtools#2139 (comment), but unfortunately no issue was ever opened in usethis.
jennybc added a commit that referenced this issue Mar 4, 2021
@jennybc
Consult CRAN-RELEASE for release sha
6afbeee 
Closes #1380
@jennybc jennybc mentioned this issue Mar 4, 2021
Merged
@jennybc jennybc added git git, GitHub, and CI in general release 🛫 wip work in progress labels Sep 28, 2021
@jennybc jennybc added this to the v2.1.0 milestone Sep 28, 2021
jennybc added a commit that referenced this issue Oct 13, 2021
@jennybc
Consult CRAN-RELEASE for release sha
a2cff0e 
Closes #1380
jennybc added a commit to r-lib/devtools that referenced this issue Oct 13, 2021
@jennybc
Put more info into CRAN-RELEASE and write it for computers, not humans
f45c182 
Relates to #2139 and r-lib/usethis#1380
@jennybc jennybc mentioned this issue Oct 13, 2021
Merged
jennybc added a commit to r-lib/devtools that referenced this issue Oct 13, 2021
@jennybc
Put more info into CRAN-RELEASE and write it for computers, not humans
a49fb46 
Relates to #2139 and r-lib/usethis#1380
@jennybc jennybc changed the title use_github_release() should use the the SHA in CRAN-RELEASE if it exists use_github_release() should use data in CRAN-RELEASE Oct 13, 2021
jennybc added a commit to r-lib/devtools that referenced this issue Oct 14, 2021
@jennybc
Put more info into CRAN-SUBMISSION and write it for computers, not hu…
f6824fb 
…mans (#2379)

* Put more info into CRAN-RELEASE and write it for computers, not humans

Relates to #2139 and r-lib/usethis#1380

* Harmonize with DESCRIPTION

* Record time as well as day

* Format the time stamp more like CRAN does in DESCRIPTION

* Whitespace

* NEWS bullet

* Switch to CRAN-SUBMISSION
jennybc added a commit that referenced this issue Oct 15, 2021
@jennybc
Consult CRAN-RELEASE for release sha
14ed031 
Closes #1380
jennybc added a commit that referenced this issue Oct 15, 2021
@jennybc
Take CRAN-SUBMISSION or CRAN-RELEASE much more seriously (#1383)
db08965 
* Consult CRAN-RELEASE for release sha

Closes #1380

* Create a helper to marshal data, from old or new CRAN-RELEASE files

PR to change what devtools writes:
r-lib/devtools#2379

* With old-style CRAN-RELEASE, the short SHA length isn't guaranteed

Apparently the meaning of `--short` in `git-rev-parse` varies. On my machine it's 8.

* Add tests

* Adapt to CRAN-SUBMISSION; get DESCRIPTION and NEWS.md from GitHub if necessary

* Add NEWS

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git git, GitHub, and CI in general release 🛫 wip work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take CRAN-SUBMISSION or CRAN-RELEASE much more seriously r-lib/usethis
2 participants
@jimhester @jennybc