Skip to content

Review all uses of getOption("devtools.SOMETHING") #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jennybc opened this issue Dec 27, 2017 · 1 comment
Closed

Review all uses of getOption("devtools.SOMETHING") #159

jennybc opened this issue Dec 27, 2017 · 1 comment
Labels
feature a feature request or enhancement wip work in progress
Milestone
v1.4.0

Comments

@jennybc
Copy link
Member

jennybc commented Dec 27, 2017

I suspect this is not implemented uniformly right now:

consult a usethis option then, if absent, consult a devtools option
@jennybc jennybc added the feature a feature request or enhancement label Jan 16, 2018
@jennybc jennybc mentioned this issue Feb 16, 2018
Closed
@jennybc
Copy link
Member Author

jennybc commented May 25, 2018 •
edited
Loading

Occurrences as of 6d32698 according to grep -nw 'getOption' * | pbcopy in R/:

  • create.R:29: fields = getOption("devtools.desc"),
  • description.R:21:#' getOption("usethis.description"), and (for backward compatibility) from
  • description.R:22:#' getOption("devtools.desc").
  • description.R:33: getOption("usethis.description") %||%
  • description.R:34: getOption("devtools.desc") %||%
  • description.R:51: author <- getOption("devtools.desc.author") %||%
  • description.R:53: license <- getOption("devtools.desc.license") %||% "What license it uses"
  • description.R:54: suggests <- getOption("devtools.desc.suggests")
  • license.R:99: name <- getOption("devtools.name")
  • license.R:104: name <- getOption("usethis.full_name")

@jennybc jennybc added this to the v1.4.0 milestone May 25, 2018
@jennybc jennybc mentioned this issue May 26, 2018
Merged
@jennybc jennybc added the wip work in progress label May 28, 2018
@llrs llrs mentioned this issue Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement wip work in progress
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@jennybc