Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_rstudio() inside of create_from_github() needs to be conservative #1679

Closed
hadley opened this issue Sep 19, 2022 · 0 comments · Fixed by #1682
Closed

use_rstudio() inside of create_from_github() needs to be conservative #1679

hadley opened this issue Sep 19, 2022 · 0 comments · Fixed by #1682
Labels
feature a feature request or enhancement git git, GitHub, and CI in general

Comments

@hadley
Copy link
Member

hadley commented Sep 19, 2022

i.e. match the line endings and don't trim whitespace. Comes up when creating PRs for revdeps

@jennybc jennybc added feature a feature request or enhancement git git, GitHub, and CI in general labels Sep 19, 2022
hadley added a commit that referenced this issue Sep 20, 2022
And set to `FALSE` in `create_from_github()`. Fixes #1679
hadley added a commit that referenced this issue Sep 21, 2022
And set to `FALSE` in `create_from_github()`. Fixes #1679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement git git, GitHub, and CI in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants