Skip to content

Should create_from_github() support subdirs? #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hadley opened this issue Sep 19, 2022 · 3 comments · Fixed by #1740
Closed

Should create_from_github() support subdirs? #1680

hadley opened this issue Sep 19, 2022 · 3 comments · Fixed by #1740
Labels
feature a feature request or enhancement git git, GitHub, and CI in general

Comments

@hadley
Copy link
Member

hadley commented Sep 19, 2022

e.g. create_from_github("https://github.com/apache/arrow/tree/master/r")
@jennybc
Copy link
Member

jennybc commented Sep 19, 2022 •
edited
Loading

How would that actually work? I.e. what sort of Git concepts / operations are we talking about.

@hadley
Copy link
Member Author

hadley commented Sep 19, 2022

I think maybe it clones in the same way, you just use_rstudio() in a subdirectory?

@hadley
Copy link
Member Author

hadley commented Nov 3, 2022

Another approach would be to scan all subdirectories for an .Rproj file before creating a new one in the root.

@hadley hadley added feature a feature request or enhancement git git, GitHub, and CI in general labels Jan 17, 2023
@hadley hadley added this to the v2.2.0 milestone Jan 18, 2023
hadley added a commit that referenced this issue Jan 19, 2023
@hadley
Look for an .Rproj file anywhere in GitHub repo
e70ec29 
Also includes some minor refactoring of `is_rstudio_project()` and `rproj_path()`

Fixes #1680
@hadley hadley mentioned this issue Jan 19, 2023
Merged
hadley added a commit that referenced this issue Jan 24, 2023
@hadley
Look for an .Rproj file anywhere in GitHub repo (#1740)
61ded87 
Also includes some minor refactoring of `is_rstudio_project()` and `rproj_path()`

Fixes #1680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement git git, GitHub, and CI in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Look for an .Rproj file anywhere in GitHub repo r-lib/usethis
2 participants
@hadley @jennybc