Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope argument for pat_sitrep()? #1732

Closed
ijlyttle opened this issue Jan 18, 2023 · 2 comments · Fixed by #1736
Closed

scope argument for pat_sitrep()? #1732

ijlyttle opened this issue Jan 18, 2023 · 2 comments · Fixed by #1736

Comments

@ijlyttle
Copy link
Contributor

In git_sitrep(), pat_sitrep() is called for both "user" and "project" scopes. Regardless of scope, it consults the "de_facto" git email:

de_facto_email <- git_cfg_get("user.email", "de_facto")

If reporting for the "user" scope, I think it should consult the "global" email address.

I think this could be addressed by adding a scope argument to pat_sitrep(); happy to offer a PR.

@jennybc
Copy link
Member

jennybc commented Jan 18, 2023

Sure, sounds good.

@ijlyttle
Copy link
Contributor Author

ijlyttle commented Feb 1, 2023

this is a duplicate of #1722

@ijlyttle ijlyttle closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants