Skip to content

Change usage of numeric_version() #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jennybc opened this issue Jun 22, 2023 · 0 comments
Closed

Change usage of numeric_version() #1869

jennybc opened this issue Jun 22, 2023 · 0 comments

Comments

@jennybc
Copy link
Member

jennybc commented Jun 22, 2023

From CRAN 2023-06-19:

A recent PR (https://bugs.r-project.org/show_bug.cgi?id=18548) showed
that whereas version inputs to numeric_version() et al were always
documented to be "suitable character vectors" (or numeric vesion
objects), the implementation also accepted numeric inputs via
as.character() coercion, the results of which however are (at least
currently) dependent on the setting of the OutDec option. We are
currently discussing the best way forward.

Meanwhile, can you please change your code to use character instead of
numeric inputs? Grepping and code analysis finds

 ./usethis/R/release.R:    return(numeric_version(0))

Please fix as quickly as possible.

I said I would do a patch release within a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant