Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_github(): be more resilient to partial setup #221

Closed
jennybc opened this issue Jan 19, 2018 · 2 comments
Closed

use_github(): be more resilient to partial setup #221

jennybc opened this issue Jan 19, 2018 · 2 comments

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Jan 19, 2018

Right now it is possible for use_github() to successfully create a GitHub repo and set a remote. But then fail to push, e.g. due to SSH key/passphrase problems.

Then, when you call it again, it exits early, because it thinks the repo already uses GitHub, because the remote is set. If you unset that, you get a new (cryptic) error because the remote repo already exists.

Could it handle "partial setup" better?

@ijlyttle
Copy link
Contributor

@ijlyttle ijlyttle commented Jan 20, 2018

Feeling shame because I should have thought to file this issue

@jennybc jennybc changed the title Can use_github() resume where it left off? use_github(): be more resilient to partial setup Feb 26, 2018
@maelle
Copy link
Contributor

@maelle maelle commented Oct 24, 2018

Could one also set push to FALSE, exposing a push argument? E.g. this way any e.g. Windows user could setup everything, and just need to push "manually" afterwards.

@hadley hadley added the git label Nov 24, 2018
hadley added a commit that referenced this issue Nov 28, 2018
Now checks individual for origin remote (i.e. is there a GitHub repo), description fields, and push-ability for master.

Fixes #221
@hadley hadley added the wip label Nov 28, 2018
@hadley hadley closed this in #516 Jan 23, 2019
hadley added a commit that referenced this issue Jan 23, 2019
* Break use_github flow into smaller pieces

Now checks individual for origin remote (i.e. is there a GitHub repo), description fields, and push-ability for master.

Fixes #221

* Be consistent with create_from_github(), use_tidy_thanks()

  We're trying to standardize on "repo_spec" to refer to a "owner/repo"
  combination

* Open repo in browser after we (hopefully) have pushed

* Add more tips for getting the git situation sorted out for use_github()

* Remove `base_path` and `path` arguments from git and github helpers

* Consistent approach to multi-line ui_stop()

* More consistent if {} else {} style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants