Fixes#276
Thanks @jeroen for all the pointers!
Key things:
* Explicit use of a handle is how we hook into progress
reporting, even though curl_download() doesn't expose
* curl_download() has a built-in check for http status 200
* Using a custom progressfunction because default doesn't
always look right in RStudio
* Switch to fs functions for file system work
* Refactor use_course() and gain progress reporting
Fixes#276
Thanks @jeroen for all the pointers!
Key things:
* Explicit use of a handle is how we hook into progress
reporting, even though curl_download() doesn't expose
* curl_download() has a built-in check for http status 200
* Using a custom progressfunction because default doesn't
always look right in RStudio
* Switch to fs functions for file system work
* Newline management
* Add NEWS bullet
* Wording
Some code shared by @jeroen in a Slack conversation about
use_course()
Other notes:
curl_fetch_disk
you can check thestatus
code also fromhandle_data()
.curl_download()
might be easier -- automatically throws an error if the result is not http 200handle_data()
to access the metadata after the requestThe text was updated successfully, but these errors were encountered: