Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any chance you'd consider exporting write_union? #366

Closed
cboettig opened this issue May 26, 2018 · 2 comments
Closed

any chance you'd consider exporting write_union? #366

cboettig opened this issue May 26, 2018 · 2 comments
Milestone

Comments

@cboettig
Copy link
Contributor

@cboettig cboettig commented May 26, 2018

Was just writing something to do this when I realized usethis must already be using such a function to update .Rbuildignore and .gitignore lists; and of course it does and looking at the source of write_union I can easily see your version is better engineered than mine. Of course I could adapt my code, but since it would then be a modification / derivation from usethis I should be crediting usethis directly and switching my license to GPL-3, and possibly listing usethis authors as ctb in the DESCRIPTION (though I sometimes worry that is misleading without proper context). All of which is obviously more cumbersome than if I could just call it as an exported function. Of course I realize my weird case is hardly a strong general case for exporting this.

@jennybc
Copy link
Member

@jennybc jennybc commented May 26, 2018

What do you think @hadley?

@hadley
Copy link
Member

@hadley hadley commented May 26, 2018

I think we could do it - we just need to think through the function name.

@jennybc jennybc added this to the v1.4.0 milestone May 26, 2018
@jennybc jennybc closed this in #389 Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.