Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum version in use_package() #386

Closed
strboul opened this issue Jun 14, 2018 · 3 comments
Closed

Set minimum version in use_package() #386

strboul opened this issue Jun 14, 2018 · 3 comments

Comments

@strboul
Copy link
Contributor

@strboul strboul commented Jun 14, 2018

I mostly require to have package version next to the package name in the DESCRIPTION file. An additional argument such as add.version to the function would be quite useful. For example:

usethis::use_package(package = "dplyr", type = "Imports", add.version = TRUE)

Then, it will be adding 'dplyr' to Imports field in DESCRIPTION:

Imports: 
    dplyr (>= 0.7.5)
@hadley
Copy link
Member

@hadley hadley commented Nov 24, 2018

I suggest we call this min_version and accept either TRUE (to use the currently installed version) or a string.

@hadley
Copy link
Member

@hadley hadley commented Nov 24, 2018

Related to #498

@hadley hadley changed the title use_package() can add package version Set minimum version in use_package() Nov 25, 2018
@hadley hadley added the wip label Nov 27, 2018
@hadley
Copy link
Member

@hadley hadley commented Nov 30, 2018

Was fixed in #512

@hadley hadley closed this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants