New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export proj_path #415

Closed
jimhester opened this Issue Jul 20, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jimhester
Member

jimhester commented Jul 20, 2018

For devtools I often need to construct the full paths to files inside a package, so it would be useful to have proj_path() exported so I wouldn't have to use something like file.path(usethis::proj_get() ...).

@jennybc

This comment has been minimized.

Show comment
Hide comment
@jennybc

jennybc Jul 20, 2018

Member

The party line on that in usethis itself is that end users are supposed to use rprojroot (or here) to build paths within a project. Do you think that also applies to you (or, more generally, developers of packages that use usethis) or is the situation different? If I export proj_path(), we'd put the same caveats as with proj_get()/proj_set() about being for internal/package use, not end-user script use.

Member

jennybc commented Jul 20, 2018

The party line on that in usethis itself is that end users are supposed to use rprojroot (or here) to build paths within a project. Do you think that also applies to you (or, more generally, developers of packages that use usethis) or is the situation different? If I export proj_path(), we'd put the same caveats as with proj_get()/proj_set() about being for internal/package use, not end-user script use.

@jimhester

This comment has been minimized.

Show comment
Hide comment
@jimhester

jimhester Jul 20, 2018

Member

I see, I guess this makes sense, you can close this if you don't think it is worthwhile.

Member

jimhester commented Jul 20, 2018

I see, I guess this makes sense, you can close this if you don't think it is worthwhile.

@jennybc

This comment has been minimized.

Show comment
Hide comment
@jennybc

jennybc Jul 20, 2018

Member

I think it probably does make sense to export it, for use in other packages. It just comes with same risk / downsides as exporting proj_get() and proj_set().

Member

jennybc commented Jul 20, 2018

I think it probably does make sense to export it, for use in other packages. It just comes with same risk / downsides as exporting proj_get() and proj_set().

jennybc added a commit that referenced this issue Aug 5, 2018

@jennybc jennybc referenced this issue Aug 5, 2018

Merged

Export proj path #425

@jennybc jennybc added this to the v1.4.0 milestone Aug 5, 2018

@jennybc jennybc closed this in #425 Aug 6, 2018

jennybc added a commit that referenced this issue Aug 6, 2018

Export proj path (#425)
* Rearrange this file

* Export proj_path()

Fixes #415

* NEWS bullet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment