Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_from_github() doesn't reset active project properly #453

Closed
jennybc opened this issue Sep 1, 2018 · 1 comment
Closed

create_from_github() doesn't reset active project properly #453

jennybc opened this issue Sep 1, 2018 · 1 comment

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Sep 1, 2018

No description provided.

@jennybc
Copy link
Member Author

@jennybc jennybc commented Sep 2, 2018

Opened as "create_from_github() doesn't reset active project properly".

But that's not really true.

The problem is that this should be handled in more of an on.exit() way. I happened to discover it via create_from_github() because I experienced a clone failure (due to git2r's usual inability to deal with ssh automatically), but the active project had already been changed. So we exited via an error and therefore did not restore active project.

hadley added a commit that referenced this issue Nov 27, 2018
Create functions now preserve the active project. This shouldn't affect people using RStudio, since a new session will be started automatically, but I think this is easier to reason about

Fixes #453
@hadley hadley added the wip label Nov 27, 2018
@hadley hadley closed this in #511 Dec 4, 2018
hadley added a commit that referenced this issue Dec 4, 2018
* Use on.exit() to ensure errors don't leave you in an unhappy place
* New proj_activate() provides user facing way of changing active project

Fixes #453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants