Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do everything we can to help macOS users to NOT commit .DS_Store #469

Closed
jennybc opened this issue Sep 28, 2018 · 10 comments
Closed

Do everything we can to help macOS users to NOT commit .DS_Store #469

jennybc opened this issue Sep 28, 2018 · 10 comments

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Sep 28, 2018

No description provided.

@ha0ye
Copy link

@ha0ye ha0ye commented Oct 18, 2018

Make or append to a global .gitignore file, then do the appropriate Git config command? Happy to work on a PR if desired.

@batpigandme

This comment has been hidden.

@jennybc

This comment has been hidden.

@batpigandme

This comment has been hidden.

@ha0ye
Copy link

@ha0ye ha0ye commented Oct 18, 2018

I think it's probably safe to add .DS_Store into the use_git function. It's handy for non-Mac users, too, as I can imagine a scenario where someone creates a repo, and then a Mac user contributes to it, uses git add ., and inadvertently commits a bunch of .DS_Store files.

Modifying global .gitignore through use_git_config would also be a nice feature to have, but as that function currently doesn't touch those files, maybe that should be left alone.

@hadley
Copy link
Member

@hadley hadley commented Nov 24, 2018

I have it in my ~/.gitignore.

If we start touching that file, we should also add .Rproj.user to it.

@hadley
Copy link
Member

@hadley hadley commented Nov 28, 2018

And also .Rhistory (since that's an easy way to accidentally share credentials).

What we call such a function? It's a bit different because it acts globally, but I think it's a safe operation to perform.

@jennybc
Copy link
Member Author

@jennybc jennybc commented Nov 29, 2018

It feels like we’re developing a notion of a system “health check” and this is a check specific to git and macOS.

@hadley
Copy link
Member

@hadley hadley commented Nov 29, 2018

Maybe we could call it vaccinate_git() (we can't use immunise() for hopefully obvious reasons)

@ijlyttle
Copy link
Contributor

@ijlyttle ijlyttle commented Nov 29, 2018

maccinate_git()? 😉

@hadley hadley closed this in 12a3a1c Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants