Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required version, if needed #498

Closed
hadley opened this issue Nov 24, 2018 · 1 comment
Closed

Bump required version, if needed #498

hadley opened this issue Nov 24, 2018 · 1 comment

Comments

@hadley
Copy link
Member

@hadley hadley commented Nov 24, 2018

Extracted from #484

use_dependency("rlang", "Imports", ">= 0.1.2") should only change the version number if it's lower than 0.1.2 (or not specified)

@hadley
Copy link
Member Author

@hadley hadley commented Nov 25, 2018

This will require changing the version argument to use_dependency() to min_version, but use_dependency() is not exported, and we only use >= restriction in existing code. I think this change will also simplify the implementation.

hadley added a commit that referenced this issue Nov 27, 2018
Includes refactoring internal use_dependency() to use it instead of more general dependency specification.

Fixes #398. Fixes #484. Fixes #498.
@hadley hadley added the wip label Nov 27, 2018
@hadley hadley closed this in #512 Nov 30, 2018
hadley added a commit that referenced this issue Nov 30, 2018
Includes refactoring internal use_dependency() to use it instead of more general dependency specification.

Fixes #398. Fixes #484. Fixes #498.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant