Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required version, if needed #498

Closed
hadley opened this issue Nov 24, 2018 · 1 comment
Closed

Bump required version, if needed #498

hadley opened this issue Nov 24, 2018 · 1 comment
Labels
description 📚 feature a feature request or enhancement wip work in progress

Comments

@hadley
Copy link
Member

hadley commented Nov 24, 2018

Extracted from #484

use_dependency("rlang", "Imports", ">= 0.1.2") should only change the version number if it's lower than 0.1.2 (or not specified)
@hadley hadley mentioned this issue Nov 24, 2018
Closed
@hadley hadley added feature a feature request or enhancement description 📚 labels Nov 24, 2018
@hadley hadley mentioned this issue Nov 24, 2018
Closed
@hadley
Copy link
Member Author

hadley commented Nov 25, 2018

This will require changing the version argument to use_dependency() to min_version, but use_dependency() is not exported, and we only use >= restriction in existing code. I think this change will also simplify the implementation.

hadley added a commit that referenced this issue Nov 27, 2018
@hadley
Add min_version to use_package()
b9b373c 
Includes refactoring internal use_dependency() to use it instead of more general dependency specification.

Fixes #398. Fixes #484. Fixes #498.
@hadley hadley mentioned this issue Nov 27, 2018
Merged
@hadley hadley added the wip work in progress label Nov 27, 2018
hadley added a commit that referenced this issue Nov 30, 2018
@hadley
Add min_version to use_package() (#512)
7c47f55 
Includes refactoring internal use_dependency() to use it instead of more general dependency specification.

Fixes #398. Fixes #484. Fixes #498.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
description 📚 feature a feature request or enhancement wip work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadley