use_article() should put the new thing below vignettes/article/

[jennybc]

use_article() should put the new thing below vignettes/article/ not just vignettes/.

[hadley]

Why? It's added to .Rbuildignore

[jennybc]

At this moment, I cannot tell you if there is a specific reason or if this just seems more correct to me. As in, it's easier at a glance to determine which things will ship with the package (vignettes) vs. those which won't (articles).

If we continue to have no specific justification, we can close if you wish.

[hadley]

I'd rather close for now, while leaving still leaving discussion about the correct behaviour for articles open (i.e. we also need to think about how we might auto link to them from pkgdown).

[jennybc]

@hadley It feels like perhaps we have decided to put non-vignette articles in vignettes/articles/, yeah? If so, then use_article() should be adjusted.

[hadley]

I'm still conflicted about non-vignette articles because we don't have any way to generate links to them in pkgdown.

[jennybc]

I see.

use_article() is a bit confused / confusing right now because it Rbuildignores vignettes/articles, as opposed to vignettes/ARTICLE_NAME.

[jennybc]

I guess this is something I recently fiddled with:

b241420

[hadley]

Re-closing because I don't think we have enough of a structure around articles to turn it into code yet. I've open r-lib/pkgdown#1247 to track the problem more broadly.

[hadley]

The current behaviour of use_article() is provably incorrect and I think the simplest fix would be to put articles into vignettes/article. I think I previously misunderstood exactly what was going in the .Rbuildignore.