Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export := with use_tidy_eval #595

Closed
jonthegeek opened this issue Jan 23, 2019 · 8 comments
Closed

Re-export := with use_tidy_eval #595

jonthegeek opened this issue Jan 23, 2019 · 8 comments

Comments

@jonthegeek
Copy link
Contributor

@jonthegeek jonthegeek commented Jan 23, 2019

:= (the tidyeval assignment operator, which I pronounce "digested is") is often as useful for tidyeval as the functions exported by the file generated via usethis::use_tidyeval(). It would be helpful if it were also re-exported.

@hadley
Copy link
Member

@hadley hadley commented Jan 23, 2019

But it doesn't actually do anything?

@jonthegeek
Copy link
Contributor Author

@jonthegeek jonthegeek commented Jan 23, 2019

Don't you need it when there's tidyeval on the LHS of a parameter assignment? When I do that, cran checks complain about := until/unless I at least import.

@batpigandme

This comment has been hidden.

@hadley
Copy link
Member

@hadley hadley commented Jan 23, 2019

Yeah, it's just a syntactic operation so the := function is never actually called (IIRC). But if R CMD check has a problem with it, we should include. @jonthegeek do you want to do a PR?

@jonthegeek
Copy link
Contributor Author

@jonthegeek jonthegeek commented Jan 23, 2019

Sure, I can probably knock this out tonight.

@jennybc
Copy link
Member

@jennybc jennybc commented Jan 24, 2019

Ironically I am getting this exact NOTE in a usethis branch, due to my use of :=.

@jennybc
Copy link
Member

@jennybc jennybc commented Jan 24, 2019

I think we need to think separately about the need for @importFrom rlang := vs. the need to re-export it. cc @lionel-

@lionel-
Copy link
Member

@lionel- lionel- commented Jan 24, 2019

Reexporting it in our packages will give a useful error message when := is used in a wrong context, so that seems helpful.

@lionel- lionel- closed this in #599 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants