Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New use_tidy_style() #72

Closed
krlmlr opened this issue Sep 15, 2017 · 2 comments
Closed

New use_tidy_style() #72

krlmlr opened this issue Sep 15, 2017 · 2 comments
Labels
feature a feature request or enhancement wip work in progress

Comments

@krlmlr
Copy link
Member

krlmlr commented Sep 15, 2017

should run styler::style_pkg(), perhaps exposing the strict argument.

@lorenzwalthert: Would you like to take a stab? It's not urgent, but eventually we'd like to point contributors to this function.
@lorenzwalthert
Copy link
Contributor

Sure. Should we wait with this until styler is released on CRAN?

@lorenzwalthert lorenzwalthert mentioned this issue Sep 25, 2017
Open
9 tasks
@hadley hadley added the feature a feature request or enhancement label Oct 12, 2017
@hadley
Copy link
Member

hadley commented Oct 12, 2017

Yeah, this will need styler on CRAN.

@lorenzwalthert lorenzwalthert mentioned this issue Jan 8, 2018
Merged
@jennybc jennybc added the wip work in progress label Jan 16, 2018
jennybc pushed a commit that referenced this issue Jan 17, 2018
@lorenzwalthert @jennybc
new use_tidy_style() (#197)
2abb042 
Closes #72

* add use_tidy_style

* add warning (c/p from styler).

* add a test

* rename testthat file

* add styler reference

* add check_uncommitted_changed

* dispatch between style_pkg and style_dir

* adapt use_dev_version() style

* avoid EOF warning

* switch to usethis:::proj_path()

* adapt to review comments

* fiddle with tests...

remove capture_output for now as suggested by reviewer to see what happens.

* mask testthat call

* printing

* fix test to not include dplyr-dependency edge case in styler.

* skip tests on R < 3.2
because git2r::discover_repository() not working on R 3.1.

* remove print statements

* fix bug for non-packages

* capture output

* remove testthat mask

* adapt help file and test description for non-packages

* final tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement wip work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hadley @jennybc @krlmlr @lorenzwalthert