Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could git_sitrep() check git vs. GitHub email? #724

Closed
ijlyttle opened this issue Apr 20, 2019 · 0 comments · Fixed by #826

Comments

@ijlyttle
Copy link
Contributor

commented Apr 20, 2019

This is one of the edge cases that came up during the workshop - someone's git email (user.email) was not registered with their GitHub account.

I wonder if something like this could be checked in git_sitrep(). I had a quick look, I don't think you're doing it now. Further, I would think that the GITHUB_PAT would need read access to user:email, which does not appear to be currently among the scopes in the default for browse_github_pat().

Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.