Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename use_tidy_versions() #771

Closed
jennybc opened this issue May 24, 2019 · 2 comments
Closed

Rename use_tidy_versions() #771

jennybc opened this issue May 24, 2019 · 2 comments
Labels

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented May 24, 2019

use_tidy_versions() is not parallel to use_tidy_ci() or use_tidy_github(), i.e. it's not enforcing a policy we embrace unconditionally. Aggressive minimum versions are another feature that can make a package feel like a heavy dependency (in addition to having lots of dependencies).

@jennybc
Copy link
Member Author

@jennybc jennybc commented Jul 2, 2019

This should possibly get split into 2 functions, instead of 1 function with source "local" vs source = "CRAN".

Brainstorming names:

  • use_installed_versions()
  • use_local_versions()
  • use_cran_versions()
  • use_released_versions()

@hadley
Copy link
Member

@hadley hadley commented Oct 17, 2019

I gave relatively little thought to the name because I don't think it's something anyone should be doing routinely. I added @keyword internal to hopefully reduce the number of people who stumble across it accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants