-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code of Conduct link in README needs to be full URL #772
Comments
Note that problem still applies even if the file is in the root directory because we |
I'm tagging this for Tidyverse-dev-day. Even if someone opts NOT to fix the logic / template in usethis, making PRs to fix READMEs in existing repos would still be great. Here's the sort of commit that's needed to fix this post hoc in the case of a package that has a pkgdown site: |
If pkgdown exposed its configuration settings, usethis could query and adapt. |
There's a new CRAN check that gets triggered by README links to files below
.github/
, such as the code of conduct.Make sure usethis's tools replace this internal link with a full URL. Probably to the file on GitHub? The one I just did "by hand" links to the file in the pkgdown site, which is probably a nice solution, but that can't really be the default strategy.
The text was updated successfully, but these errors were encountered: