Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui_yeah and ui_nope option choices and ordering #796

Closed
rundel opened this issue Jul 1, 2019 · 1 comment · Fixed by #810
Closed

ui_yeah and ui_nope option choices and ordering #796

rundel opened this issue Jul 1, 2019 · 1 comment · Fixed by #810
Labels
feature a feature request or enhancement tooling 🔨 Internal usethis tooling

Comments

@rundel
Copy link
Contributor

rundel commented Jul 1, 2019

I like both of these functions and would like to use them in ghclass when users request potentially destructive actions. However, I'd like the option to control what choices are presented to the user and whether or not they are randomized.

Both of these behaviors were also unclear to me from the docs.

Happy to propose a modified version of both if that would be helpful.

@jennybc
Copy link
Member

jennybc commented Jul 2, 2019

It sounds like you might have some good suggestions for the docs here and also that you might ultimately want to inline versions of these functions in ghclass. A PR to drive discussion would be great.

@jennybc jennybc added feature a feature request or enhancement tooling 🔨 Internal usethis tooling labels Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement tooling 🔨 Internal usethis tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants