Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_github_action() should .Rbuildignore the entire .github folder #943

Closed
DavisVaughan opened this issue Nov 20, 2019 · 2 comments
Closed

Comments

@DavisVaughan
Copy link
Member

Right now, when I use use_github_actions_tidy() I end up with this in .Rbuildignore:

^\.github/workflows/R-CMD-check\.yaml$
^\.github/workflows/pr-commands\.yaml$

If I run devtools::build() I'll get these empty directory notes:

> devtools::build()
✔  checking for file/Users/davis/Desktop/r/packages/hardhat/DESCRIPTION...preparinghardhat: (885ms)
✔  checking DESCRIPTION meta-information ...installing the package to process help pagescreating vignettes (5.8s)
─  checking for LF line-endings in source and make files and shell scripts (400ms)
─  checking for empty or unneeded directories
   Removed empty directoryhardhat/.github/workflowsRemoved empty directoryhardhat/.github’
─  buildinghardhat_0.0.0.9001.tar.gz

Should use_github_action() just add ^\.github$ to `.Rbuildignore?

@jennybc
Copy link
Member

jennybc commented Nov 20, 2019

There are several functions that write into .github/ so it's probably time to add a helper that does the right/better thing for all of them.

@hadley
Copy link
Member

hadley commented Mar 14, 2020

@jimhester fixed this recently

@hadley hadley closed this as completed Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants