Attempt to clarify pr_fetch() vs pr_resume() #1734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
approved these changes
Jan 18, 2023
Member
jennybc
left a comment
jennybc
left a comment
There was a problem hiding this comment.
This the only deleted sentence that I'm a bit sad to see go:
#' ... `pr_fetch()` puts a
#' maintainer in a position where they can push changes into an internal or
#' external PR via `pr_push()`.
Member
Author
|
I didn't go with that exact wording, but hopefully communicated the same message. |
DavisVaughan
approved these changes
Jan 19, 2023
| #' and pulling any changes from its upstream tracking branch, if it has one. If | ||
| #' called with no arguments, up to 9 local branches are offered for interactive | ||
| #' selection, with a preference for branches connected to PRs and for branches | ||
| #' with recent activity. |
Member
There was a problem hiding this comment.
Should we mention that pr_resume() can be useful if you've used pr_pause() but have not yet called pr_push()? But otherwise we generally use pr_fetch() because you can reference by PR number and that is typically a little easier?
Member
Author
There was a problem hiding this comment.
I added some text to pr_pause() to hopefully help here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665