-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement use_standalone()
#1748
Conversation
Requires r-lib/rlang#1548 |
#Conflicts: # NEWS.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is a draft and is unfinished, but I made one pass on my way through the usethis notifications.
Note to self: unskip "use_tidy_dependencies() isn't overly informative" test when this concludes. |
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used it here and it worked well! tidyverse/dplyr#6722
Co-authored-by: Davis Vaughan <davis@rstudio.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main thing to settle is whether to make this work for GHE. I think we should do it, since we've met that standard everywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the caveat that I didn't manually test on GHE, yes, I think this is good to go (after you take my suggestion to pass host
to standalone_choose()
).
One last suggestion: in create_from_github()
, perhaps we should clarify the docs a bit, now they are being inherited elsewhere.
Such as:
For create_from_github()
, the REPO
part will be the name of the new local folder, which is also a project and Git repo.
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
@jennybc the docs were a bit tangled, but I think I've made an improvement. Anyway, I'm going to merge this PR so it's off my plate, and you should feel free to tweak the docs as you see fit. |
Fixes #1654