Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement use_standalone() #1748

Merged
merged 22 commits into from
Feb 16, 2023
Merged

Implement use_standalone() #1748

merged 22 commits into from
Feb 16, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 22, 2023

Fixes #1654

@hadley
Copy link
Member Author

hadley commented Jan 30, 2023

Requires r-lib/rlang#1548

Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is a draft and is unfinished, but I made one pass on my way through the usethis notifications.

@jennybc
Copy link
Member

jennybc commented Feb 10, 2023

Note to self: unskip "use_tidy_dependencies() isn't overly informative" test when this concludes.

@hadley hadley marked this pull request as ready for review February 10, 2023 22:40
@hadley hadley requested a review from DavisVaughan February 10, 2023 22:50
@hadley hadley requested a review from jennybc February 10, 2023 23:07
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used it here and it worked well! tidyverse/dplyr#6722

@hadley hadley changed the title First pass at use_compat() Implement use_standalone() Feb 14, 2023
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main thing to settle is whether to make this work for GHE. I think we should do it, since we've met that standard everywhere else.

Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that I didn't manually test on GHE, yes, I think this is good to go (after you take my suggestion to pass host to standalone_choose()).

One last suggestion: in create_from_github(), perhaps we should clarify the docs a bit, now they are being inherited elsewhere.

Such as:

For create_from_github(), the REPO part will be the name of the new local folder, which is also a project and Git repo.

hadley and others added 3 commits February 16, 2023 15:29
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
@hadley
Copy link
Member Author

hadley commented Feb 16, 2023

@jennybc the docs were a bit tangled, but I think I've made an improvement. Anyway, I'm going to merge this PR so it's off my plate, and you should feel free to tweak the docs as you see fit.

@hadley hadley merged commit 56bb801 into main Feb 16, 2023
@hadley hadley deleted the use-compat branch February 16, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide use_compat() for managing common compat-[pkg].R files
3 participants