Bump default serialization version in use_data() to 3#2044
Merged
Conversation
jennybc
reviewed
Aug 15, 2024
jennybc
left a comment
Member
There was a problem hiding this comment.
Looking good!
Can you take a look at the docs for the version argument? They state that the default is 2, which is not correct anymore. So this needs a refresh.
#' @param version The serialization format version to use. The default, 2, was
#' the default format from R 1.4.0 to 3.5.3. Version 3 became the default from
#' R 3.6.0 and can only be read by R versions 3.5.0 and higher.
Member
|
I think we do have a test that claims to probe default behaviour but it's clearly not working! Because it actually provides the Would you also like to fix and update this test? |
Contributor
Author
|
Hi Jenny thanks for all your help (and patience!) I incorporated both your notes above! |
Member
|
Thanks! |
This was referenced Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1966 - The grand sum of this update is one character (plus a news bullet) Note that this change did not break anything in any test (should a test be added?)