Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for CRAN badge image. #235

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
2 participants
@jdblischak
Copy link
Contributor

jdblischak commented Feb 4, 2018

I changed the URL for the CRAN badge image to use HTTPS. The HTTP URL caused my pkgdown site hosted on GitHub Pages to be labeled as insecure (jdblischak/workflowr#96).

The HTTPS URL appears to work, e.g. here is the badge for usethis using HTTPS: CRAN status

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Feb 13, 2018

Thanks! Will you add a bullet to NEWS?

@jdblischak

This comment has been minimized.

Copy link
Contributor Author

jdblischak commented Feb 13, 2018

Thanks! Will you add a bullet to NEWS?

Happy to! And I rebased my commit to avoid any conflict when merging the changes in NEWS.md. Thanks!

@jennybc jennybc merged commit 0c4008d into r-lib:master Feb 13, 2018

4 checks passed

codecov/patch 100% of diff hit (target 62.6%)
Details
codecov/project 62.6% (+0%) compared to da3f07a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.