Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added use_tibble() to enable printing for exported objects #324

Merged
merged 8 commits into from May 24, 2018
Merged

Added use_tibble() to enable printing for exported objects #324

merged 8 commits into from May 24, 2018

Conversation

@charliejhadley
Copy link
Contributor

@charliejhadley charliejhadley commented Apr 4, 2018

usethis::use_tibble() when used within a package will add the necessaries for exported tibbles from the package to be printed correctly as tibbles.

An example of where this could have been useful is when gapminder upgraded from data.frame to tibbles in this commit jennybc/gapminder@bf439dd

I believe I've followed the PR process fully, except I didn't create an issue I went straight to a PR.

charliejhadley and others added 8 commits Apr 4, 2018
@jennybc
Copy link
Member

@jennybc jennybc commented May 24, 2018

Thanks! I tweaked a few things (which creates commits in your fork btw!). Next time you might want to make the PR from a non-master branch.

@jennybc jennybc merged commit 5749e6f into r-lib:master May 24, 2018
4 checks passed
4 checks passed
codecov/patch 83.33% of diff hit (target 62.13%)
Details
codecov/project 62.21% (+0.08%) compared to 8d63fcb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@charliejhadley
Copy link
Contributor Author

@charliejhadley charliejhadley commented May 25, 2018

Thanks for the heads up, I'll remember to do this next time 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants