Broken with \n in title #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e problem (interactive use only)
…e problem (interactive use only)
…e problem (interactive use only)
…e problem (interactive use only)
…e problem (interactive use only)
…e problem (interactive use only)
…e problem (interactive use only)
…e problem (interactive use only)
jennybc
requested changes
Nov 13, 2018
Would you be willing to branch off current usethis master and make a new PR? I think the semi-complicated history of master branch in your fork is making the optics of this PR more challenging.
| @@ -28,6 +28,9 @@ use_git <- function(message = "Initial commit") { | |||
| if (yep(commit_consent_msg)) { | |||
| done("Adding files and committing") | |||
| git2r::add(r, paths) | |||
| if (length(paths) > 0) { | |||
There was a problem hiding this comment.
I feel git_uncommitted() (in the condition for this block) implies that paths has non-zero length. Have you seen something to the contrary?
There was a problem hiding this comment.
This PR part was for #128
There was a problem hiding this comment.
If there are two different issues, let's split into two PRs then.
There was a problem hiding this comment.
LIttle swamped now, will within next week or 2.
|
Closing in favour of two smaller PRs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It looks as though 65764fa#diff-4ac879304421b0c163d57d6d4be6b43dL89 changed the
gsubpart of thepkg$Titleforrepo_descinuse_github, which causesgh::ghto fail if there is a newline\n.This should revert that behavior.