Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_tidy_description() sets Encoding #502

Merged
merged 4 commits into from Nov 26, 2018
Merged

use_tidy_description() sets Encoding #502

merged 4 commits into from Nov 26, 2018

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 24, 2018

Not tested, because scoped_temporary_package() already sets the Encoding field.

Closes #444.

@jayhesselberth
Copy link
Contributor

@jayhesselberth jayhesselberth commented Nov 25, 2018

Not sure how this addresses #467?

@hadley
Copy link
Member

@hadley hadley commented Nov 25, 2018

I think he meant #444

@hadley
Copy link
Member

@hadley hadley commented Nov 25, 2018

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@hadley hadley merged commit 8b2b448 into r-lib:master Nov 26, 2018
1 check was pending
@hadley
Copy link
Member

@hadley hadley commented Nov 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants