Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds use_ccby_license() to add a CCBY 4.0 license (#547) #612

Merged
merged 7 commits into from Mar 16, 2019

Conversation

njtierney
Copy link
Contributor

This resolves #547

Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a bullet for this up above in the docs that is parallel to the others? Where it says "... with one of four popular open source license [sic]", just change to "... with one of these open source licenses:".

R/license.R Outdated

use_description_field("License",
"CCBY-4.0",
overwrite = TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use styler on the bits you're changing? Re: indentation and line breaks, specifically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this with the styler adding, but it looks like the style is inconsistent with other functions in license.R - did you want me to run it on the whole license.R file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure it's fine to style this whole file.

NEWS.md Outdated
@@ -2,6 +2,8 @@

## New features

* `use_ccby_license()` adds a CCBY 4.0 license (#547)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also put your GitHub username here (look around NEWS for examples).

@njtierney
Copy link
Contributor Author

OK, done!

@jennybc jennybc merged commit d560af4 into r-lib:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: use_ccby_license()
2 participants