Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check GitHub email with sitrep #826

Merged
merged 6 commits into from Jul 21, 2019

Conversation

@dragosmg
Copy link
Contributor

commented Jul 8, 2019

closes #724

@dragosmg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Is there anything else I need to do - should I add a bullet point in news?

dragosmg added some commits Jul 9, 2019

@dragosmg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

does the example on the package website need to be modified?
https://usethis.r-lib.org/reference/git_sitrep.html

@jennybc

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Nice! The example will update itself when the website is re-built and deployed, although it won't be very satisfying anyway, since the dummy travis user has no PAT.

@jennybc jennybc merged commit 9ffc27f into r-lib:master Jul 21, 2019

3 of 4 checks passed

codecov/patch 0% of diff hit (target 46.86%)
Details
codecov/project 46.73% (-0.14%) compared to c3ad943
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dragosmg dragosmg deleted the dragosmg:check_github_email_with_sitrep branch Jul 23, 2019

avalcarcel9 added a commit to avalcarcel9/usethis that referenced this pull request Aug 14, 2019

Merge branch 'master' of https://github.com/r-lib/usethis
* 'master' of https://github.com/r-lib/usethis:
  Better (broader) RBuildignore entry for articles
  Update tidy-issue.md (r-lib#848)
  Add `use_lifecycle()` (r-lib#842)
  Tweak release issue
  Add reminder to check CRAN results to release checklist
  Pedantry but I can't help myself
  Check GitHub email with sitrep (r-lib#826)
  Fix use_circleci (r-lib#835)
  Make git_branch_compare() aware of explicit credentials
  Add a test for use_lgpl_license(); add NEWS bullet (r-lib#825)
  add verbose PAT message (r-lib#828)
  Revise `ui_yeah` / `ui_nope` (r-lib#810)
  Tweak regex
  Edit the issue template
  Add TODO
  We now depend on fs >= 1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.