Fix use_circleci #835
Merged
Fix use_circleci #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids mess age about empty directory from `R CMD build`: * checking for empty or unneeded directories Removed empty directory ‘usethis/.circleci’
|
@jennybc Thanks for cleaning up my PR and merging it! |
avalcarcel9
added a commit
to avalcarcel9/usethis
that referenced
this pull request
Aug 14, 2019
* 'master' of https://github.com/r-lib/usethis: Better (broader) RBuildignore entry for articles Update tidy-issue.md (r-lib#848) Add `use_lifecycle()` (r-lib#842) Tweak release issue Add reminder to check CRAN results to release checklist Pedantry but I can't help myself Check GitHub email with sitrep (r-lib#826) Fix use_circleci (r-lib#835) Make git_branch_compare() aware of explicit credentials Add a test for use_lgpl_license(); add NEWS bullet (r-lib#825) add verbose PAT message (r-lib#828) Revise `ui_yeah` / `ui_nope` (r-lib#810) Tweak regex Edit the issue template Add TODO We now depend on fs >= 1.3.0
jennybc
pushed a commit
that referenced
this pull request
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
use_circleci()today and found a few bugs:The mustache delimiters caused the cache keys to be corrupted. I fixed this by using alternative delimiters, as suggested here
R CMD buildmentioned that it removed the empty.circlecidirectory. Apparently ignoring the only file it contains doesn't also ignore the entire directory. Thus I also explicitly ignored the directory itselfI added tests for both of these updates and also ran styler on the code changes.