Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_circleci #835

Merged
merged 4 commits into from Jul 21, 2019
Merged

Fix use_circleci #835

merged 4 commits into from Jul 21, 2019

Conversation

@jdblischak
Copy link
Contributor

@jdblischak jdblischak commented Jul 12, 2019

I used use_circleci() today and found a few bugs:

  • The mustache delimiters caused the cache keys to be corrupted. I fixed this by using alternative delimiters, as suggested here

  • R CMD build mentioned that it removed the empty .circleci directory. Apparently ignoring the only file it contains doesn't also ignore the entire directory. Thus I also explicitly ignored the directory itself

I added tests for both of these updates and also ran styler on the code changes.

jdblischak and others added 4 commits Jul 12, 2019
Avoids mess age about empty directory from `R CMD build`:

* checking for empty or unneeded directories
Removed empty directory ‘usethis/.circleci’
@jennybc jennybc merged commit c920862 into r-lib:master Jul 21, 2019
0 of 2 checks passed
@jdblischak
Copy link
Contributor Author

@jdblischak jdblischak commented Jul 23, 2019

@jennybc Thanks for cleaning up my PR and merging it!

avalcarcel9 added a commit to avalcarcel9/usethis that referenced this issue Aug 14, 2019
* 'master' of https://github.com/r-lib/usethis:
  Better (broader) RBuildignore entry for articles
  Update tidy-issue.md (r-lib#848)
  Add `use_lifecycle()` (r-lib#842)
  Tweak release issue
  Add reminder to check CRAN results to release checklist
  Pedantry but I can't help myself
  Check GitHub email with sitrep (r-lib#826)
  Fix use_circleci (r-lib#835)
  Make git_branch_compare() aware of explicit credentials
  Add a test for use_lgpl_license(); add NEWS bullet (r-lib#825)
  add verbose PAT message (r-lib#828)
  Revise `ui_yeah` / `ui_nope` (r-lib#810)
  Tweak regex
  Edit the issue template
  Add TODO
  We now depend on fs >= 1.3.0
jdblischak added a commit to jdblischak/usethis that referenced this issue Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants