adds AGPL license and explicitly refers to it and to LGPL in DESCRIPTION #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Oct 16, 2019
There was a problem hiding this comment.
Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
usethis.Rproj
Outdated
| @@ -18,4 +18,4 @@ StripTrailingWhitespace: Yes | |||
| BuildType: Package | |||
| PackageUseDevtools: Yes | |||
| PackageInstallArgs: --no-multiarch --with-keep.source | |||
| PackageRoxygenize: rd,collate,namespace | |||
There was a problem hiding this comment.
Can you please revert this change?
|
ok, @hadley |
|
Thanks! |
jennybc
reviewed
Oct 17, 2019
| @@ -11,7 +11,11 @@ | |||
| #' provides patent protection. | |||
| #' * [GPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing | |||
| #' of improvements. | |||
| #' * [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/): Free to share and | |||
| #' * [AGPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing | |||
There was a problem hiding this comment.
This URL looks wrong. Shouldn't it be:
|
That's right! I'll edit and commit
…On Thu, Oct 17, 2019, 2:46 PM Jennifer (Jenny) Bryan < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In R/license.R
<#870 (comment)>:
> @@ -11,7 +11,11 @@
#' provides patent protection.
#' * [GPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing
#' of improvements.
-#' * [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/): Free to share and
+#' * [AGPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing
This URL looks wrong. Shouldn't it be:
https://choosealicense.com/licenses/agpl-3.0/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#870?email_source=notifications&email_token=ACM7UOKVVO64RBNZFSCZQG3QPCQHDA5CNFSM4IKXUMPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCILAMYI#pullrequestreview-303433313>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM7UOJI3F7AONBSXSU32SLQPCQHDANCNFSM4IKXUMPA>
.
|
|
Ready. New PR with the change.
…On Thu, Oct 17, 2019, 2:46 PM Jennifer (Jenny) Bryan < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In R/license.R
<#870 (comment)>:
> @@ -11,7 +11,11 @@
#' provides patent protection.
#' * [GPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing
#' of improvements.
-#' * [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/): Free to share and
+#' * [AGPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing
This URL looks wrong. Shouldn't it be:
https://choosealicense.com/licenses/agpl-3.0/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#870?email_source=notifications&email_token=ACM7UOKVVO64RBNZFSCZQG3QPCQHDA5CNFSM4IKXUMPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCILAMYI#pullrequestreview-303433313>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM7UOJI3F7AONBSXSU32SLQPCQHDANCNFSM4IKXUMPA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
It can be useful for Shiny apps to have the option to use AGPL-3 license. The detail is exactly as asked and replied here: https://stackoverflow.com/questions/2127246/difference-between-affero-gpl-and-gplv3#2127313