Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds AGPL license and explicitly refers to it and to LGPL in DESCRIPTION #870

Merged
merged 6 commits into from Oct 16, 2019

Conversation

@pachadotdev
Copy link
Contributor

@pachadotdev pachadotdev commented Aug 9, 2019

Hi!
It can be useful for Shiny apps to have the option to use AGPL-3 license. The detail is exactly as asked and replied here: https://stackoverflow.com/questions/2127246/difference-between-affero-gpl-and-gplv3#2127313

Copy link
Member

@hadley hadley left a comment

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

usethis.Rproj Outdated
@@ -18,4 +18,4 @@ StripTrailingWhitespace: Yes
BuildType: Package
PackageUseDevtools: Yes
PackageInstallArgs: --no-multiarch --with-keep.source
PackageRoxygenize: rd,collate,namespace
Copy link
Member

@hadley hadley Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert this change?

@pachadotdev
Copy link
Contributor Author

@pachadotdev pachadotdev commented Oct 16, 2019

ok, @hadley
solved merge conflicts, .Rproj (using yours) and edited NEWS as requested

@hadley hadley merged commit 42cdeef into r-lib:master Oct 16, 2019
3 of 4 checks passed
@hadley
Copy link
Member

@hadley hadley commented Oct 16, 2019

Thanks!

@@ -11,7 +11,11 @@
#' provides patent protection.
#' * [GPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing
#' of improvements.
#' * [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/): Free to share and
#' * [AGPL v3](https://choosealicense.com/licenses/gpl-3.0/): requires sharing
Copy link
Member

@jennybc jennybc Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL looks wrong. Shouldn't it be:

https://choosealicense.com/licenses/agpl-3.0/

@pachadotdev
Copy link
Contributor Author

@pachadotdev pachadotdev commented Oct 17, 2019

@pachadotdev
Copy link
Contributor Author

@pachadotdev pachadotdev commented Oct 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants