Allow invalid CRAN names #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stop_for_name controls whether to throw error for invalid CRAN package names - Default to warning for use_description(), error for create_package() - Add tests - update NEWS
jennybc
reviewed
Sep 10, 2019
- Simplify check logic with elimination of warnings - Update tests - Re-document
jennybc
reviewed
Sep 11, 2019
R/description.R
Outdated
| @@ -97,17 +101,16 @@ build_description_list <- function(fields = list()) { | |||
| compact(utils::modifyList(defaults, fields)) | |||
| } | |||
|
|
|||
| check_package_name <- function(name) { | |||
| check_package_name <- function(name, stop_for_name) { | |||
There was a problem hiding this comment.
I think the signature can revert to just being name, right?
| test_that("valid CRAN names checked", { | ||
| withr::local_options(list(usethis.description = NULL, devtools.desc = NULL)) | ||
| scoped_temporary_package(dir = file_temp(pattern = "invalid_pkg_name")) | ||
| expect_error(use_description(check_name = FALSE), NA) |
There was a problem hiding this comment.
We've got expect_error_free() for this (defined in tests/testthat/helper.R).
noamross
force-pushed
the
non-cran-desc
branch
from
5dae6a1
to
01cc846
Compare
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop_for_namecontrols whether to throw errorfor invalid CRAN package names
use_description(), errorfor
create_package()I am unsure if
stop_for_nameis the best argument name, open to other suggestions!Closes #528