Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export use_github_action function #958

Merged
merged 1 commit into from Dec 13, 2019
Merged

export use_github_action function #958

merged 1 commit into from Dec 13, 2019

Conversation

@smwindecker
Copy link
Contributor

smwindecker commented Dec 13, 2019

Discussed with @jimhester this morning at ozunconf that this functionality to call actions from marketplace url's should be exported

@jennybc jennybc requested a review from jimhester Dec 13, 2019
@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Dec 13, 2019

LGTM, thanks @smwindecker!

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Dec 13, 2019

@smwindecker I think you need to run devtools::document() to that the new export causes the requisite change in NAMESPACE.

I'll eventually do this myself and merge, but if you do it first, even better.

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Dec 13, 2019

@jennybc the namespace already has the change in this PR unless I am missing something https://github.com/r-lib/usethis/pull/958/files#diff-7347fe5a0f184f79ef064e92e3beb297R106

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Dec 13, 2019

@jennybc the namespace already has the change in this PR unless I am missing something

Oh, that's odd, isn't it 🤔? I mean ... how did that happen? I was just looking at this PR in isolation.

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Dec 13, 2019

Oh, sorry. Nevermind all.

@jennybc jennybc merged commit afdd6e0 into r-lib:master Dec 13, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smwindecker

This comment has been minimized.

Copy link
Contributor Author

smwindecker commented Dec 14, 2019

Thanks @jennybc! Yes not sure why it looked like a check had failed. I felt pretty confident leaving it though, as I knew the documentation was updated.

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Dec 15, 2019

The travis failure is some other, unrelated thing. This looks like an intermittent failure, plus there are at least 2 other travis gremlins lurking this week. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.