Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_logo url converting https://* to https:/* #986

Merged
merged 2 commits into from Jan 24, 2020
Merged

Fix use_logo url converting https://* to https:/* #986

merged 2 commits into from Jan 24, 2020

Conversation

mitchelloharawild
Copy link
Contributor

@mitchelloharawild mitchelloharawild commented Jan 24, 2020

> usethis::use_logo("hex/icon.svg")
✔ Copied 'hex/icon.svg' to 'man/figures/logo.svg'
● Add logo to your README with the following html:
  # icon <a href='https:/pkg.mitchelloharawild.com/icon'><img src='man/figures/logo.svg' align="right" height="139" /></a>
  [Copied to clipboard]

This PR fixes the URL https:/* to be https://*. I don't think treating the URL as a path here is necessary, as it is from pkgdown config.

@jennybc
Copy link
Member

@jennybc jennybc commented Jan 24, 2020

Thanks!

@jennybc jennybc merged commit 4194fd6 into r-lib:master Jan 24, 2020
3 of 4 checks passed
@mitchelloharawild mitchelloharawild deleted the logo branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants