Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec_cbind() drops rows with zero column data frames #1281

Closed
DavisVaughan opened this issue Oct 16, 2020 · 1 comment · Fixed by #1282
Closed

vec_cbind() drops rows with zero column data frames #1281

DavisVaughan opened this issue Oct 16, 2020 · 1 comment · Fixed by #1282

Comments

@DavisVaughan
Copy link
Member

DavisVaughan commented Oct 16, 2020

I expect 1 row, 0 cols:

vctrs::vec_cbind(vctrs::new_data_frame(n = 1L), vctrs::new_data_frame(n = 1L))
#> data frame with 0 columns and 0 rows

Created on 2020-10-16 by the reprex package (v0.3.0.9001)

Comes up in tune where i make pretty heavy usage of zero col data frames

@DavisVaughan
Copy link
Member Author

I think we just need to pass Rf_ScalarInteger(nrow) through here instead of R_NilValue

out = vec_restore(out, type, R_NilValue, VCTRS_OWNED_true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant