Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec_equal_na should use all for data frames #201

Closed
hadley opened this issue Feb 23, 2019 · 1 comment
Closed

vec_equal_na should use all for data frames #201

hadley opened this issue Feb 23, 2019 · 1 comment

Comments

@hadley
Copy link
Member

hadley commented Feb 23, 2019

Not any, as currently.

Consider the case of dropping missing values — you only want to drop rows where all values are missing. This will make rcrds and data frames different, which I think makes sense (since a rcrds row represents a single value, but a data frame row represents many)

@hadley
Copy link
Member Author

hadley commented Feb 26, 2019

But we can't make data frames and rcrds behave differently here because the comparison happens via vec_proxy_equal(). But maybe that's ok — if a record wants to behave differently here, it should probably be providing its own proxy.

@hadley hadley closed this as completed in 2540f4a Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant