Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should vec_proxy_compare() have a fallback? #210

Open
hadley opened this issue Feb 28, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@hadley
Copy link
Member

commented Feb 28, 2019

It would be nice to be able to sort data frames containing list columns. Should vec_proxy_compare() return seq_along(x)? Or should it return NULL, and then failures would be communicated downstream?

@hadley

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

This is needed for (e.g.) tidyr::crossing() and nesting() because (for historical reasons) these sort all columns.

hadley added a commit that referenced this issue Feb 28, 2019

Add relax argument vec_compare_proxy
Quick hack to unblock tidyr development. Needs fuller consideration in #210.

@lionel- lionel- added the op:compare label Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.