Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should vec_proxy_compare() have a fallback? #210

Open
hadley opened this issue Feb 28, 2019 · 2 comments
Open

Should vec_proxy_compare() have a fallback? #210

hadley opened this issue Feb 28, 2019 · 2 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Feb 28, 2019

It would be nice to be able to sort data frames containing list columns. Should vec_proxy_compare() return seq_along(x)? Or should it return NULL, and then failures would be communicated downstream?

@hadley
Copy link
Member Author

@hadley hadley commented Feb 28, 2019

This is needed for (e.g.) tidyr::crossing() and nesting() because (for historical reasons) these sort all columns.

hadley added a commit that referenced this issue Feb 28, 2019
Quick hack to unblock tidyr development. Needs fuller consideration in #210.
@lionel- lionel- added the compare label Mar 7, 2019
@DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented Sep 2, 2020

For sorting list columns we have changed usage vec_proxy_compare(relax = TRUE) to instead use vec_proxy_order(). This "orders" list column elements by first appearance, which seemed reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants