-
Notifications
You must be signed in to change notification settings - Fork 67
vec_rbind with packed and nested data frames #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jeroen It seems jsonlite creates data frames whose rownames attribute is not negative: rlang:::sexp_attrib(pages[[1]])
#> $names
#> [1] "sha" "node_id" "commit" "url"
#> [5] "html_url" "comments_url" "author" "committer"
#> [9] "parents"
#>
#> $class
#> [1] "data.frame"
#>
#> $row.names
#> [1] NA 30 I'm not sure this is standard, but it seems base R is ok with it. Here is how it normally looks like: rlang:::sexp_attrib(data.frame(1:10))
#> $names
#> [1] "X1.10"
#>
#> $class
#> [1] "data.frame"
#>
#> $row.names
#> [1] NA -10 @hadley Would it make sense to use Line 56 in 6b8c98a
|
Hmm, is this part of the new altrep shorthand for a series of integers? Indeed I see rlang:::sexp_attrib(pages[[1]])
#> $names
#> [1] "sha" "node_id" "commit" "url"
#> [5] "html_url" "comments_url" "author" "committer"
#> [9] "parents"
#>
#> $class
#> [1] "data.frame"
#>
#> $row.names
#> [1] NA 30 But attributes(pages[[1]])
#> $names
#> [1] "sha" "node_id" "commit" "url" "html_url" "comments_url" "author"
#> [8] "committer" "parents"
#>
#> $class
#> [1] "data.frame"
#>
#> $row.names
#> [1] 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 |
It is supposed to be negative (see also I'll change it to |
I'm still seeing |
With the current master? |
Updated all of my dev packages and it works now. Probably some dev dependency... |
Real world examples of packed and nested data
No packed / nested data frames
Packed data frames
Nested data frames
The
flatten
argument infromJSON
converts packed into nested data frames:The text was updated successfully, but these errors were encountered: