Skip to content

vec_rbind(.id = <?>, .name_repair=<?> ) ... #229

Description

@romainfrancois

This is somewhat a followup of this dplyr PR tidyverse/dplyr#4250 and related issue tidyverse/dplyr#4230

Can/should vec_rbind() have an .id argument ?

Should vec_rbind() obey name repair rules, and have a .name_repair= argument ?

are duplicated column names allowed, and if yes, how should they behave, this feels wrong:

library(vctrs)
library(tibble)

d1 <- tibble(x = 1:2, x = letters[3:4], .name_repair = "minimal")
d2 <- tibble(x = 5:6)

vec_rbind(d1)
#> # A tibble: 2 x 2
#>       x x    
#>   <int> <chr>
#> 1     1 1    
#> 2     2 2
vec_rbind(d1, d2)
#> # A tibble: 4 x 2
#>       x     x
#>   <int> <int>
#> 1     1     1
#> 2     2     2
#> 3     5     5
#> 4     6     6

Created on 2019-03-07 by the reprex package (v0.2.1.9000)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions