Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec_rbind(.id = <?>, .name_repair=<?> ) ... #229

Closed
romainfrancois opened this issue Mar 7, 2019 · 0 comments · Fixed by #436
Closed

vec_rbind(.id = <?>, .name_repair=<?> ) ... #229

romainfrancois opened this issue Mar 7, 2019 · 0 comments · Fixed by #436
Milestone

Comments

@romainfrancois
Copy link
Contributor

romainfrancois commented Mar 7, 2019

This is somewhat a followup of this dplyr PR tidyverse/dplyr#4250 and related issue tidyverse/dplyr#4230

Can/should vec_rbind() have an .id argument ?

Should vec_rbind() obey name repair rules, and have a .name_repair= argument ?

are duplicated column names allowed, and if yes, how should they behave, this feels wrong:

library(vctrs)
library(tibble)

d1 <- tibble(x = 1:2, x = letters[3:4], .name_repair = "minimal")
d2 <- tibble(x = 5:6)

vec_rbind(d1)
#> # A tibble: 2 x 2
#>       x x    
#>   <int> <chr>
#> 1     1 1    
#> 2     2 2
vec_rbind(d1, d2)
#> # A tibble: 4 x 2
#>       x     x
#>   <int> <int>
#> 1     1     1
#> 2     2     2
#> 3     5     5
#> 4     6     6

Created on 2019-03-07 by the reprex package (v0.2.1.9000)

@hadley hadley added this to the 0.2.0 milestone Jun 3, 2019
lionel- added a commit to lionel-/vctrs that referenced this issue Jun 17, 2019
lionel- added a commit to lionel-/vctrs that referenced this issue Jun 18, 2019
lionel- added a commit to lionel-/vctrs that referenced this issue Jun 19, 2019
lionel- added a commit to lionel-/vctrs that referenced this issue Jun 20, 2019
lionel- added a commit to lionel-/vctrs that referenced this issue Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants