Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec_c( <complex>, NA) #564

Closed
romainfrancois opened this issue Sep 5, 2019 · 3 comments · Fixed by #673
Closed

vec_c( <complex>, NA) #564

romainfrancois opened this issue Sep 5, 2019 · 3 comments · Fixed by #673
Milestone

Comments

@romainfrancois
Copy link
Contributor

@romainfrancois romainfrancois commented Sep 5, 2019

library(vctrs)

vec_c(2 + 1i, NA)
#> No common type for `..1` <complex> and `..2` <vctrs_unspecified>.

Created on 2019-09-05 by the reprex package (v0.3.0.9000)

@hadley hadley added this to the 0.3.0 milestone Nov 13, 2019
@romainfrancois

This comment has been minimized.

Copy link
Contributor Author

@romainfrancois romainfrancois commented Nov 18, 2019

Also :

vctrs::vec_c(1, 1+1i)
#> Error: No common type for `..1` <double> and `..2` <complex>.

Created on 2019-11-18 by the reprex package (v0.3.0.9000)

related to tidyverse/dplyr#4614

lionel- added a commit to lionel-/vctrs that referenced this issue Nov 18, 2019
@lionel- lionel- closed this in #673 Nov 18, 2019
lionel- added a commit that referenced this issue Nov 18, 2019
Closes #564
@yogat3ch

This comment has been minimized.

Copy link

@yogat3ch yogat3ch commented Dec 1, 2019

@lionel- From tidyverse/dplyr#4614

A similar issue is happening when using bind_rows() with a column of periods on dplyr_0.8.99.9000:

  test <- list()
test$a <- data.frame(a = rep(lubridate::now(), 10), p = rep(lubridate::hm("0:30"), 10))
test$b <- data.frame(a = rep(lubridate::now(), 10), p = rep(lubridate::hm("0:50"), 10))

dplyr::bind_rows(test)
#> Error: No common type for `a$p` <Period> and `b$p` <Period>.

Created on 2019-12-01 by the reprex package (v0.2.1)

@DavisVaughan

This comment has been minimized.

Copy link
Collaborator

@DavisVaughan DavisVaughan commented Dec 2, 2019

Looks like this would be taken care of with tidyverse/lubridate#721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.