Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make C level vec_proxy_equal() recursive by default #641

Closed
DavisVaughan opened this issue Nov 1, 2019 · 4 comments · Fixed by #693
Closed

Make C level vec_proxy_equal() recursive by default #641

DavisVaughan opened this issue Nov 1, 2019 · 4 comments · Fixed by #693

Comments

@DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented Nov 1, 2019

See #636 (review)

It is not currently used non-recursively anywhere anymore, so we might not even need vec_proxy_equal_shallow().
@lionel-
Copy link
Member

@lionel- lionel- commented Nov 28, 2019

It seems like the R level vec_proxy() should also be recursive. And then restoration as well.

@lionel-
Copy link
Member

@lionel- lionel- commented Nov 28, 2019

E.g. there might be a grouped-df column whose group indices need to be restored after slicing.

lionel- added a commit to lionel-/vctrs that referenced this issue Nov 28, 2019
@lionel-
Use vec_proxy_equal() instead of vec_proxy_recursive()
076a9a5 
Part of r-lib#641
@lionel- lionel- mentioned this issue Nov 28, 2019
Merged
lionel- added a commit to lionel-/vctrs that referenced this issue Nov 28, 2019
@lionel-
Use vec_proxy_equal() instead of vec_proxy_recursive()
ea8e9b2 
Part of r-lib#641
@lionel-
Copy link
Member

@lionel- lionel- commented Nov 28, 2019

oops vec_proxy() cannot be recursive because vec_restore() cannot be recursive. We can't restore recursively since the number of columns or their contents might change.

It's possible vec-proxy and vec-proxy-equal are in fact unrelated concepts.

@lionel-

This comment has been minimized.

Sign in to view
lionel- added a commit to lionel-/vctrs that referenced this issue Dec 2, 2019
@lionel-
Use vec_proxy_equal() instead of vec_proxy_recursive()
2b7249b 
Part of r-lib#641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make equality proxy recursive over data frames lionel-/vctrs
2 participants
@lionel- @DavisVaughan