Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec_equal(list(NULL), list(NULL)) returns TRUE #653

Closed
DavisVaughan opened this issue Nov 8, 2019 · 1 comment · Fixed by #655
Closed

vec_equal(list(NULL), list(NULL)) returns TRUE #653

DavisVaughan opened this issue Nov 8, 2019 · 1 comment · Fixed by #655

Comments

@DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented Nov 8, 2019

This should return NA right? Unless na_equal = TRUE?

vctrs::vec_equal(list(NULL), list(NULL))
#> [1] TRUE

Problem line:

case NILSXP:

@DavisVaughan DavisVaughan changed the title vec_equal(list(NULL), list(NULL)) vec_equal(list(NULL), list(NULL)) returns TRUE Nov 8, 2019
@hadley
Copy link
Member

@hadley hadley commented Nov 8, 2019

Right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants