New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take care of known list classes #723
Comments
I think these should be fixed downstream. |
Can we keep this list here? |
Yes, I've also added a "base" section to your post. Reprex for pkg-version: vctrs::vec_is(packageVersion("tibble"))
#> [1] FALSE
data.frame(a = packageVersion("tibble"))
#> a
#> 1 2.99.99.9011 Created on 2020-01-02 by the reprex package (v0.3.0) Required for {pkgsearch}. |
lionel-
added a commit
to r-lib/rlang
that referenced
this issue
Feb 25, 2020
Closes #928 Part of r-lib/vctrs#723
lionel-
added a commit
to lionel-/vctrs
that referenced
this issue
Feb 25, 2020
lionel-
added a commit
to lionel-/vctrs
that referenced
this issue
Feb 25, 2020
lionel-
added a commit
to lionel-/vctrs
that referenced
this issue
Feb 28, 2020
Closing now, since tibble has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From tibble's revdepchecks, I see the following S3 classes that wrap a list and are a vector:
Base classes should be fixed in vctrs:
"package_version"
These will need to be fixed in downstream packages, either by implementing vec-proxy or by adding an explicit
"list"
at the end of the vector class."bench_expr"
"data.frame"
(?????)"lst_mdl"
"lazy_dots"
(???)"quosures"
"trelliscope_panels"
"ad_int_list"
"mixed_units"
Related: #666.
The text was updated successfully, but these errors were encountered: