Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take care of known list classes #723

Closed
2 of 9 tasks
krlmlr opened this issue Jan 2, 2020 · 4 comments
Closed
2 of 9 tasks

Take care of known list classes #723

krlmlr opened this issue Jan 2, 2020 · 4 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Jan 2, 2020

From tibble's revdepchecks, I see the following S3 classes that wrap a list and are a vector:

Base classes should be fixed in vctrs:

  • "package_version"

These will need to be fixed in downstream packages, either by implementing vec-proxy or by adding an explicit "list" at the end of the vector class.

  • bench: "bench_expr"
  • concurve: "data.frame" (?????)
  • feasts: "lst_mdl"
  • heemod: "lazy_dots" (???)
  • jstor, textrecipes: "quosures"
  • PML: "trelliscope_panels"
  • psychmeta: "ad_int_list"
  • units: "mixed_units"

Related: #666.

@lionel-
Copy link
Member

lionel- commented Jan 2, 2020

I think these should be fixed downstream.

@krlmlr
Copy link
Member Author

krlmlr commented Jan 2, 2020

Can we keep this list here?

@lionel-
Copy link
Member

lionel- commented Jan 3, 2020

Yes, I've also added a "base" section to your post. Reprex for pkg-version:

vctrs::vec_is(packageVersion("tibble"))
#> [1] FALSE
data.frame(a = packageVersion("tibble"))
#>              a
#> 1 2.99.99.9011

Created on 2020-01-02 by the reprex package (v0.3.0)

Required for {pkgsearch}.

lionel- added a commit to r-lib/rlang that referenced this issue Feb 25, 2020
lionel- added a commit to lionel-/vctrs that referenced this issue Feb 25, 2020
lionel- added a commit to lionel-/vctrs that referenced this issue Feb 25, 2020
lionel- added a commit to lionel-/vctrs that referenced this issue Feb 28, 2020
lionel- added a commit that referenced this issue Feb 28, 2020
@lionel-
Copy link
Member

lionel- commented Apr 20, 2020

Closing now, since tibble has been released.

@lionel- lionel- closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants